dail8859 / dail8859/NotepadNext

Encoding in StatusBar

Open
#405 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
14.6k
Forks
914
Avg merge
6d 18h
Merged PRs (30d)
7

Description

The encoding in the status bar currently shows the code page of the editor.
instead of the file's encoding.

You may open a non-UTF-8 encoding file to reproduce the issue.
And there are many test files in uchardet: `NotepadNext\src\uchardet\test`

https://github.com/dail8859/NotepadNext/blob/6ab835404de7b0b4c7ee3ed47dc9aeaeae745ba1/src/NotepadNext/widgets/EditorInfoStatusBar.cpp#L148-L150

https://github.com/dail8859/NotepadNext/blob/6ab835404de7b0b4c7ee3ed47dc9aeaeae745ba1/src/NotepadNext/ScintillaNext.cpp#L524

----

I am not sure how to fix this issue:
1. Update `editor->codePage()` after detecting the file encoding
2. Or add a new property (in `ScintillaNext`) to save the file encoding

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.