Enhancement - Science screen - show multiple shields in multiple lines to prevent string from being cut off
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 869
- Forks
- 222
- Avg merge
- 18h 33m
- Merged PRs (30d)
- 1
Description
In the Science screen, for targets with multiple shields, the shields are concatenated into one long string, which can get cut off by the edge of the game window:
The Game Master screen shows multiple shields in multiple rows, here is what the same target looks like in release EE-2024.12.08:
I propose the Science screen show each shield in its own row.
Notes for implementation:
In the current master branch, the Game Master screen has that code commented out:
link to the commit diff which commented it out in the Game Master screen
Code in Science Screen where the long string is made:
The Science screen has a single GuiKeyValueDisplay to show the shields, while the Game Master screen uses a std::unordered_map<string, string>. The unordered map means sometimes the shields are out of order in the Game Master screen:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/screens/crew6/scienceScreen.cpp at the shield string construction around lines 399-402, then compare it with the commented shield-row code in src/screens/gm/gameMasterScreen.cpp. The work is done when the Science screen displays each shield on its own row without being cut off, while preserving a consistent shield order.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100