[Scenario issues] Outpost / player_ship_upgrade_downgrade_path_scenario_utility - In progress
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 869
- Forks
- 222
- Avg merge
- 18h 33m
- Merged PRs (30d)
- 1
Description
Tested on the last offical release of 08 décembre 2024 to proofreading my fr translations on Outpost / player_ship_upgrade_downgrade_path_scenario_utility / cpu_ship_diversification_scenario_utility.fr.
a. If I want to add player ships before launching the Doomed Outpost scenario, I get the following errors (see screenshots) with several ships like Benedict, Ender, Kiriya, MP52, Phobos M3p...
And another one when I check DB shipyard
b. A translation tag is missing line 4557. "desc = "increase short range sensors by ~9%","
c. In DB, Hathcock upgrade 3: "increase arc width by 50%" increases the arc of laser beam 2 but not the
laser beam 1. And upgrade 6 "increase arc width by 12.5%" increases the arc of laser beam 3 but not the
laser beam 1 and 2.
d. Additionally, the same phrase "increase arc width by 50%" is used for the Benedict level 4 and Ender level 5
for example but on the other hand in these cases, it increases the arc of the laser turrets and not the arc of the laser beams.
The phrase "increase arc by 50%" which we can see for example in upgrade 3 of the Flavia P. Falcon does increase the arc of the laser beams.
In this case, Hathcock upgrade 3 should be "increase arc by 50%" as well and not "increase arc width by 50%" And same thing for Hatchcock upgrade 6 "increase arc width by 12.5%" should be "increase arc by 12.5%".
Otherwise I can't differentiate upgrade laser turrets from laser beams in the translations.
I will let you know if I find this problem in other places.
EDIT : After looking closer, this text "" is used for 11 upgrades and sometimes it concerns the turrets and sometimes the beams.
In other upgrade texts, Turret is well specified. There is confusion.
I think you should just specify "turret" in the text when it comes to the arc of turrets like "increase turret arc by ..."
e. In DB, MP52 Hornet upgrade 2 does not have the correct text "increase range by 25%" line 7577 because the range goes from 800 (0.8u) to 900 (0.9u), which is 12.5%.
f. Like d. In DB, Pirhana upgrade 9 (line 3729) does not have the correct text "double arc width "or it's the 3 others upgrades (l1796 Benedict, l2282 kiriya, l7927 zx-lindworm) that use this text because it concerns turrets and not for the piranha.
g. Line 482 There is a calculation error, it is not 13% but 9%
{idx = 0, max = 230},
{idx = 1, max = 230},
["desc"] = _("upgrade-comms","increase shield charge capacity by 15%"),
["downgrade"] = _("downgrade-comms","reduced shield charge capacity by 8%"),
},
{ --10
{idx = 0, max = 250},
{idx = 1, max = 250},
["desc"] = _("upgrade-comms","increase shield charge capacity by ~13%")
h. Line 9164 There is a calculation error for Raven, it is not "increase hull max by ~17%" but "increase hull max by ~11%"
i. Like f. and d. In DB, Repulse upgrade 3 use this sentence "increase arc by 1/3" to increase the arc of the turrets. But this same text is also used 2x for the laser beam arc and 4x for the turret arc.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Outpost player_ship_upgrade_downgrade_path_scenario_utility data, especially cpu_ship_diversification_scenario_utility.fr and the referenced lines 4557, 7577, 3729, 482, 9164, and 1796/2282/7927. Compare the reported ship upgrade values and descriptions, then check the DB shipyard and scenario errors. Done means the reported errors, missing translation tag, ambiguous turret/beam wording, and percentage calculations are corrected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev, localization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100