daid / daid/EmptyEpsilon

[Scenario issues] Carrier and Turret

Open
#2,256 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
869
Forks
222
Avg merge
18h 33m
Merged PRs (30d)
1

Description

I am putting back here what I noted as problems in this scenario and already exchanged with @Xansta who knows that this scenario requires a good revision.
It's easier to follow up here than in pm.

I am testing the CarrierTurret scenario to check my translations (in French version) with the release of 04Nov2024 and I notice several problems:

a. Unlike before, the carrier can dock at stations and purchase goods etc. even if rarely you have to start twice. The text of the main objective should be modified.

b. If 2 ships: the carrier and 1 of the 2 other ships are docked at different stations, they can buy goods but their stock is common.
If one buys and fills the available space, the other will no longer be able to buy, for example. Which is weird since they're so far apart. This varies the common stock available which sometimes rises to 15.

c. The game crashed several times recently with this scenario but I don't know why. it seems to me that it is when I contact a station.

d. When I contact a freighter I got sometimes this error message in GM. See picture.
interrogé un cargo

e. Asking a station about the types of goods that can be found elsewhere will display goods in multiple copies. See picture
Edit : In Escape for example, there are no duplicates but this is apparently because 2 different stations do not sell the same type of goods. Whereas in Carrier and Turret, if several stations offer the same good, it is not grouped in the comms menu. It would be better if it was grouped/sorted by goods rather than by station.

food food food

f. The following text: "Where are you headed? (cost: %f reputation)" line 4207, displays the reputation cost with 6 digits after the decimal point. “3.236919 reputation” for example.

g. Line 5922 This end message on the mainscreen contains an error: "Enemy Stations: %i survived: %i destroyed: %i"

After destroying only the enemy station, it displays: "Enemy Stations: 7 survived: 6 destroyed: 6"

h. I'm having trouble checking my translations in this scenario. Except for one sub-mission (Upgrade Maneuver) or even 2 (tube addition), nothing else happens. If I click on the different GM P2 P3 buttons, it does not trigger the other sub-missions, even if you wait a long time. Nothing happens anymore, I couldn't test further. But maybe that's a misunderstanding on my part. If anyone else could test this to confirm or deny ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CarrierTurret scenario and inspect the reported line references 4207 and 5922, then reproduce the station, freighter, goods-list, crash, and sub-mission behaviors using the French translation test setup. Compare the scenario with Escape where relevant. Done means each reported behavior is reproduced or explained, corrected, and covered by verification of the scenario flow and displayed messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.