Configuration path should have single source of truth
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 869
- Forks
- 222
- Avg merge
- 18h 33m
- Merged PRs (30d)
- 1
Description
Back when I made #2047 I only changed one of apparently four (I realized it because of #1437) places where the configuration path is being decided. It would make sense to just have one single place where the selection logic is run.
My suggestions would be to either:
- have a static function in PreferencesManager that computes the configuration path and returns it, or
- compute it in main.cpp and somehow store it in PreferencesManager (either as a preference or with its own getter/setter)
If I get told which way is prefered, I will implement it and make a pull request. (Also if wished I could directly incorporate #1437 in it.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the four places where the configuration path is selected, then review the changes in #2047 and the related issue #1437. Compare the PreferencesManager and main.cpp approaches described in the issue, and confirm with maintainers which design is preferred. Done means configuration-path selection has one source of truth and the #1437 change is included if requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100