daid / daid/EmptyEpsilon

[Issue] When the player ship docks at a station, it jerks

Open Beginner friendly
#2,000 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
869
Forks
222
Avg merge
18h 33m
Merged PRs (30d)
1

Description

❔ When the player ship docks at a station, it jerks until the motors stop. It is also permanent in the scenario "Birth of Atlantis" with JC-88.
Starry refers to this : https://github.com/daid/EmptyEpsilon/blob/04327e23e2eb1c045abdd4d458c73e2bcbeadb3a/src/spaceObjects/spaceship.cpp#L988C13-L988C29 should also have current_impulse = 0; added

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open src/spaceObjects/spaceship.cpp at the docking-related code around line 988 and inspect how current_impulse is handled when the ship docks. Reproduce the issue in the “Birth of Atlantis” scenario with JC-88, then verify that docking no longer causes the ship to jerk after the motors stop.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.