Incorrect export string generation
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 869
- Forks
- 222
- Avg merge
- 18h 33m
- Merged PRs (30d)
- 1
Description
If a ship has its reverse impulse speed then when export to clipboard is used it will export with "setImpulseMaxReverseSpeed" (an undefined lua function) rather than using setImpulseMaxSpeed with 2 parameters
Presumibly the issue is here https://github.com/daid/EmptyEpsilon/blob/3489f30940ce2c5c1c3b3d1653d4805e94c99123/src/spaceObjects/spaceship.cpp#L1766 , and will be an easy fix
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/spaceObjects/spaceship.cpp around line 1766 and inspect the export-to-clipboard string generation for a ship with reverse impulse speed. Verify the generated Lua uses the supported setImpulseMaxSpeed form with two parameters, then confirm the exported string no longer names setImpulseMaxReverseSpeed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100