daid / daid/EmptyEpsilon

[ServerScenarioSelection] Scenario names aren't updated if language changed

Open
#1,878 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
869
Forks
222
Avg merge
18h 33m
Merged PRs (30d)
1

Description

  1. Launch EE in English.
  2. Start a server.
  3. Select a scenario category. Observe the scenario names' language.
  4. Return to the main menu.
  5. Open Options.
  6. Change the language to French.

Expected behavior:

Scenario names are in French.

Observed behavior:

Scenario names are in English.

This occurs with any two languages that have translated scenario names, in any order.

ScenarioInfo does not appear to be reloaded after changing the language. Adding logging on ScenarioInfo initialization:

INFO: ServerScenarioSelectionScreen created
INFO: Scenario info loaded
INFO: ScenarioInfo name: Bataille simple (Basic Battle)
INFO: Scenario info loaded
INFO: ScenarioInfo name: Encerclés (Surrounded)
INFO: Scenario info loaded
...
INFO: Loading scenario list
INFO: Entry: Bataille simple
INFO: Entry: Encerclés
INFO: Entry: Vagues
INFO: Entry: Entrainement : Croiseur
...
(language changed in options menu from French to English)
...
INFO: ServerScenarioSelectionScreen created
(no "Scenario info loaded" lines)
INFO: Loading scenario list
INFO: Entry: Bataille simple
INFO: Entry: Encerclés
INFO: Entry: Vagues
INFO: Entry: Entrainement : Croiseur

See also #1876.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at ServerScenarioSelectionScreen and the ScenarioInfo initialization or loading path, then compare what happens when returning after changing the language in the Options menu. Trace why the scenario list is reused without refreshed translated names. Done means scenario names reflect the newly selected language for the reported language-switch sequence, including switching between any translated languages.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev, localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.