[ServerScenarioSelection] Scenario names aren't updated if language changed
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 869
- Forks
- 222
- Avg merge
- 18h 33m
- Merged PRs (30d)
- 1
Description
- Launch EE in English.
- Start a server.
- Select a scenario category. Observe the scenario names' language.
- Return to the main menu.
- Open Options.
- Change the language to French.
Expected behavior:
Scenario names are in French.
Observed behavior:
Scenario names are in English.
This occurs with any two languages that have translated scenario names, in any order.
ScenarioInfo does not appear to be reloaded after changing the language. Adding logging on ScenarioInfo initialization:
INFO: ServerScenarioSelectionScreen created
INFO: Scenario info loaded
INFO: ScenarioInfo name: Bataille simple (Basic Battle)
INFO: Scenario info loaded
INFO: ScenarioInfo name: Encerclés (Surrounded)
INFO: Scenario info loaded
...
INFO: Loading scenario list
INFO: Entry: Bataille simple
INFO: Entry: Encerclés
INFO: Entry: Vagues
INFO: Entry: Entrainement : Croiseur
...
(language changed in options menu from French to English)
...
INFO: ServerScenarioSelectionScreen created
(no "Scenario info loaded" lines)
INFO: Loading scenario list
INFO: Entry: Bataille simple
INFO: Entry: Encerclés
INFO: Entry: Vagues
INFO: Entry: Entrainement : Croiseur
See also #1876.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ServerScenarioSelectionScreen and the ScenarioInfo initialization or loading path, then compare what happens when returning after changing the language in the Options menu. Trace why the scenario list is reused without refreshed translated names. Done means scenario names reflect the newly selected language for the reported language-switch sequence, including switching between any translated languages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev, localization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100