PlayerSpaceship:getBeamSystemTargetName returns "UNKNOWN" for hull
Open
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 869
- Forks
- 222
- Avg merge
- 18h 33m
- Merged PRs (30d)
- 1
Description
getBeamSystemTarget() returns -1 when a PlayerSpaceship targets the hull instead of a system, but the ESystem string conversion function getSystemName doesn't handle that value.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the ESystem string conversion function getSystemName in src/shipTemplate.cpp, linked in the issue, and trace how PlayerSpaceship:getBeamSystemTargetName uses the -1 result from getBeamSystemTarget(). Done means the hull target no longer produces "UNKNOWN" and the existing conversion behavior for system targets remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100