daid / daid/EmptyEpsilon

Crash on startup when using unknown model in lua file

Open
#138 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
869
Forks
222
Avg merge
18h 33m
Merged PRs (30d)
1

Description

When trying to add more ships to the shipTemplates.lua, I made a typo in the model to use. This caused a crash on startup.

We really should add better / more gracefull errror handling, as the scripting should never cause the application to crash.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the startup crash with an invalid model entry in shipTemplates.lua, then trace how that file is loaded and how unknown models are handled. Define the desired graceful behavior from the issue: a scripting error should not crash the application, and verify startup remains usable with the typo present.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.