dagster-io / dagster-io/helm-user-cloud

feat(rbac): seperate rbac creation from service account creation

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
2
Forks
2
PR merge metrics
No merged PRs in 30d

Description

In the helm chart `templates/role.yaml` and `templates/rolebinding.yaml`, the creation of RBAC is tied to the `serviceAccount.create` flag.

It is pretty common for managed K8S deployments to create the service account and namespace prior to invoking the helm chart as the helm installation role might not have the permissions needed to create the service account on the cluster.

The general approach is to have a separate "[rbac.create](https://helm.sh/docs/chart_best_practices/rbac/#rbac-resources-should-be-created-by-default)" flag which defaults to `true` as it is far more likely a consumer will setup and create their own service account as opposed to change the needed permissions required by the helm chart.

I see in `templates/serviceaccount.yaml` you can provide permissions related annotations via `serviceAccount.annotations`, but this doesn't address the problem mentioned where the helm installer might not have privileges to create a service account.

**Note**: I looked for another repository without the released version of the chart and could not find one, and assume it is internally managed so created the issue here.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with templates/role.yaml and templates/rolebinding.yaml, then inspect templates/serviceaccount.yaml and the chart’s configuration to understand how serviceAccount.create currently controls resource creation. Render the chart with the relevant flags to verify that rbac.create defaults to true and independently controls RBAC resources while service-account creation remains configurable.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.