daangn / daangn/stackflow

다른 호스트로 이동해야할 때 처리에 관하여

Open
#629 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1k
Forks
114
Avg merge
3m
Merged PRs (30d)
2

Description

(english question follows korean)

안녕하세요, StackFlow 도입 과정에서 기술적인 확인이 필요하여 질문드립니다!

서비스를 만들며 PG 결제 / SNS 로그인처럼 특정 상황에서 서비스 외부로 이동했다가 다시 특정 Activity로 돌아오는 수요가 있는데요.
이 수요를 어떤 방식으로 구현하는게 당근 팀에서 생각하는 모범답안일지가 궁금합니다.

지금 당장 생각했던 방향성으로는, 페이지 이동 / 팝업등의 이벤트를 가로채 외부 서비스일 경우,
사전에 준비한 iframe만 존재하는 Activity로 이동을 시켜 프로세스를 진행하게 하는것이 제일 먼저 생각나는데요.

이럴 경우에는 iframe에서 프로세스가 완료되었을때 postMessage 등을 사용해서 callback 처리를 별도로 해야하는 불편함이 생기지만,
지금의 상황에서는 가장 최적해라고 판단할수도 있는데요.

-> SOP 문제를 잊고 있었네요 🫠

혹시라도 실제로 사용하고 계신 레퍼런스 / 더 좋은 구현 방안이 있다면 같이 논의해보면 행복할 듯 합니다!
감사합니다 :)

--

Hello, I have a question regarding the technical aspects of StackFlow implementation.

While developing a service, there's a need to navigate outside the service and then return to a specific activity in certain situations, such as PG payments or SNS logins.
I'm curious about the Carrot team's best approach for implementing this requirement.

The direction I'm currently considering is intercepting events like page transitions and pop-ups, and if it's an external service,
the first thing that comes to mind is to navigate to an activity that only contains a pre-prepared iframe and proceed with the process.

This approach requires a separate callback using postMessage or something similar when the process is completed in the iframe, which is inconvenient.
But for the current situation, this may be the most optimal solution.

-> I forgot about the SOP issue. 🫠

If you have any references or better implementations you're using, I'd be happy to discuss them!
Thank you :)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by reviewing StackFlow's existing activity, navigation, and plugin surfaces for external PG-payment or SNS-login flows; done would require an agreed implementation approach, which this discussion does not yet define.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, mobile-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
18/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.