daaain / daaain/Handlebars

Review block expression opening and closing tag colours

Open
#98 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
303
Forks
48
PR merge metrics
No merged PRs in 30d

Description

As per @tyleha's comment on #95, now HTML tags have the same colour as block expression opening and closing tags, which isn't great.

The distinction of block tags is useful I think (as mentioned in #94), but we should pick a different scope.

There's a list of scopes here: http://www.sublimetext.com/docs/3/scope_naming.html#color_schemes

But I couldn't find a nice way to see these visualised, so it's a bit of a trial and error to see what colour is which. Also, the scope should be semantically correct.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the syntax scope definitions that assign colors to HTML tags and block expression opening and closing tags. Review the Sublime Text scope naming reference linked in the issue, then verify that a semantically appropriate alternative scope produces distinct colors for both constructs.

Written by the indexing model from the issue text.

Assessment

Tech stack
handlebars, html, javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.