dOrgTech / dOrgTech/NectarDAO-Bootstrapper

Approval timing issues

Open
#28 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

### Situation
* The user has not enabled their token (GEN or NEC for the respective schemes)
* The user presses the 'Enable' button on the 'Please enable' screen shown
* The panel goes into the pending state

### Issues
* Panel can return from the pending view back to the 'Please enable' screen, confusing the user
* The panel will update to post-approval view once the core blockchain polling loop returns new data.

This is due to how async operations are handled - the pending state is set when we start the TX in metamask, and stopped when that returns as done.

This can happen at a different time then the core polling loop, which checks if the user has enabled their token. If they have, it shows the post-approval view in the panel.

Perhaps ideally, we'd see if the transaction returned on the core polling loop.

As a stopgap, you could add in a call to see if the user has approved token after the metamask call, and then return pending after that.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.