d3plus / d3plus/d3plus

multi-language support in TextBox

Open
#741 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.6k
Forks
180
PR merge metrics
No merged PRs in 30d

Description

Hi, I've read your blog post https://blog.datawheel.us/english-is-not-chinese-69b43959bb47, thanks for the work! But the example does not work when Chinese is combined with English, when putting an English sentence between, spaces between English words does not show up.

Expected Behavior

Spaces of English words show correctly

Current Behavior

Spaces between English words disappears

Steps to Reproduce (for bugs)

http://jsfiddle.net/gest45z9/12/

Your Environment
  • Browser Name: Chrome
  • Operating System and Version: MacOS Sierra v10.12.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked jsfiddle reproduction and the TextBox implementation, using the reported Chrome-on-MacOS case with Chinese and English as the failing example. Confirm that spaces between English words disappear when the languages are combined, then verify that those spaces render correctly without breaking the existing Chinese text behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.