d2phap / d2phap/ImageGlass

PNG gamma correction

Open
#377 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🛠 improvement
Dominant language
C#
Stars
14.4k
Forks
752
Avg merge
10d 14h
Merged PRs (30d)
1

Description

The following images show different in Firefox/Chrome versus ImageGlass. ImageGlass should probably respect the gAMA and sRGB PNG chunks.

gAMA chunk 0.02 (shows apple when no gamma correction is applied, pear when it is):

sRGB chunk (shows checkered 0/255 and 1/255 when no gamma correction is applied, 1/255 squares are higher when it is):

gAMA chunk 1.0 (checkered 0/255 and 1/255, for comparison with srgb.png above):

Possibly related to #368.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the three linked PNG examples in ImageGlass and comparing them with Firefox or Chrome. Then locate the PNG decoding or rendering path and check how the gAMA and sRGB chunks are handled. Done means the examples render consistently with the expected gamma-corrected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
computer-graphics, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.