Embedded color profiles are detected, but not tagged color profiles
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 14.4k
- Forks
- 752
- Avg merge
- 10d 14h
- Merged PRs (30d)
- 1
Description
Windows OS version
Windows 10 22H2
ImageGlass version
9.3.2.520 (64-bit)
ImageGlass release
Classic
1️⃣ Steps to reproduce
In Jeffrey Friedl's Blog there's a post explaining how color profiles are included in images: either "embedded" or "tagged"
Download the test images under the "Tagged" section, for example, Momiji-sRGB-tagged.jpg and Momiji-AdobeRGB-tagged.jpg, then view these images in ImageGlass.
2️⃣ Actual behavior
Apparently the images have different colors when viewed in ImageGlass, the color of "Momiji-AdobeRGB-tagged.jpg" is noticeably duller than "Momiji-sRGB-tagged.jpg", likely because the tagged color profile wasn't detected. (and yes, it's normal if the colors are also different when viewed in browsers, because browsers typically can't detect tagged color profiles either, but dedicated image software often can)
3️⃣ Expected behavior
Those images should have pretty much the same color tone (if you check those images in a dedicated image software such as Photoshop or ACDSee Pro, they should have the same color tone, as expected).
4️⃣ Screenshots / Video / Sample image file
5️⃣ Additional context
When a color profile is "tagged" instead of "embedded", it means the color profile is just defined in the image's metadata. This is usually done for color profiles that are already relatively common (e.g. AdobeRGB, AppleRGB, etc.).
ImageGlass does detect embedded ones as expected, but not tagged ones (which I'm assuming isn't intentional as I didn't find an existing Github issue about this), perhaps it's a good idea to still be able to detect the common color profiles when they're tagged instead of embedded?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior in ImageGlass 9.3.2.520 on Windows 10 22H2 using Momiji-sRGB-tagged.jpg and Momiji-AdobeRGB-tagged.jpg from the linked test images. Compare the displayed tones with dedicated image software and trace how ImageGlass handles embedded versus metadata-defined profiles. Done means both tagged images display with the expected matching color tone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- computer-graphics, desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100