d2phap / d2phap/ImageGlass

Missing embedded color profile information at the top for Display P3 images

Open
#2,050 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🐞 bug
Dominant language
C#
Stars
14.4k
Forks
752
Avg merge
10d 14h
Merged PRs (30d)
1

Description

System information
  • Windows OS version: Windows 10
  • ImageGlass version: 9.1.8.723 (64-bit)
  • ImageGlass release: Store / Classic? Classic

#############

To Reproduce

Steps to reproduce the behavior:

  1. Open image with a Display P3 embedded color profile
  2. Look at the top. It should be missing the "/Display P3" part

#############

Explanation

For some time I was wondering why ImageGlass was slightly saturating sRGB images on my sRGB monitor, because those images would show in ImageGlass:
Image Glass displays as sRGB

Later I saw an image that actually has an embedded sRGB profile and it displayed in ImageGlass:
Correct srgb

That's when I decided to see the correct embedded color profile of that first image by importing it on Photoshop and I saw:
embedded Display P3
The image isn't actually sRGB, it's Display P3. ImageGlass is displaying the wrong embedded color profile for Display P3 images. So that explains my confusion.

Expected behavior

ImageGlass should say "sRGB/Display P3" like it does for every other color profile, or images without color profile embedded:
example 1
example 2
example 3

#############

Additional context

Color management works perfectly as intended. It just displays the wrong embedded color profile at the top for Display P3 images

Thanks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the issue with an image containing an embedded Display P3 profile, then locate the code that formats the color-profile text shown at the top. Done means the display identifies the profile as "sRGB/Display P3" while preserving the existing color-management behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
computer-graphics, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.