Full screen mode turns off Gallery panel, Toolbar after quitting and zooming out doesn't return to scale to fit
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 14.4k
- Forks
- 752
- Avg merge
- 10d 14h
- Merged PRs (30d)
- 1
Description
System information
- Windows OS version: 11
- ImageGlass version: 9.1.7.627 (64-bit)
- ImageGlass release: Classic
To Reproduce
Steps to reproduce the behavior 1:
- Turn on Toolbar (T) and Gallery panel (G)
- Go Fullscreen (F11)
- Hit Esc to quit viewing
- View images again, it keeps the Fullscreen state which is understandable, but going out of Fullscreen would turn off Toolbar and Gallery panel
Steps to reproduce the behavior 2:
- Open an image
- Zoom out or zoom in and out
- Image doesn't stay fit to the windows
Actual behavior
As stated in Steps to reproduce 1 and 2
Expected behavior
Issue 1:
- Turn on Toolbar (T) and Gallery panel (G)
- Go Fullscreen (F11)
- Hit Esc to quit viewing
- View images again, keeps the Fullscreen state which is understandable, but going out of Fullscreen would NOT turn off Toolbar and Gallery panel
Issue 2:
- Open an image
- Zoom out or zoom in and out
- Image stays fit to the windows no matter how much you zoom out, because the viewing mode is "Scale to fit"
Screenshots / Video / Sample image file
Issue 1
https://github.com/d2phap/ImageGlass/assets/153918815/a66230b5-d56f-4c9b-a596-9aa0bee12bb6
Issue 2
https://github.com/d2phap/ImageGlass/assets/153918815/57ee9cca-2db6-4ce5-9d89-ad8ec700be98
Additional context
There's probably enough context so I'm gonna add my suggestion:
Issue 2 can be solved through adding a free zoom/scaling option, because zooming out the furthest should stay consistent with the scaling you're using to view the images, not zooming it out further.
Also ImageGlass can still benefit from a little more speed/performance boost (even with run on startup enable) as it's a tiny bit slower than Windows 11 stock Photos app, especially noticeably different when moving between photos in a gallery of 12000x6000 pixels. Still, thank you for making an image viewing apps with proper color management for professionals 🙂
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named in the issue. Reproduce the fullscreen toolbar/Gallery behavior and the Scale to fit zoom behavior first; done means the toolbar and Gallery remain enabled after leaving fullscreen and Scale to fit remains effective after zooming.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100