d2phap / d2phap/ImageGlass

Changing "loading orders" during slideshow does not override the original setting from before the slideshow was started

Open
#1,816 2 comments 0 reactions 1 assignee View on GitHub

@d2phap is already working on this.

Since Jan 8, 2024.

🐞 bug
Dominant language
C#
Stars
14.4k
Forks
752
Avg merge
10d 14h
Merged PRs (30d)
1

Description

System information:
  • Windows OS version: Windows 11 Pro 22H2 (22621.2861)
  • ImageGlass version: 9.0.9.1230 (64-bit)
To Reproduce

Steps to reproduce the behavior:

  1. Open any image within a folder containing multiple images
  2. Note whatever the chosen "Loading Orders" selection is
  3. Start a slideshow
  4. Change the "Loading Orders" selection to something different
  5. Note that the order does not actually change despite the newly chosen option staying selected. When you exit the slideshow, the original loading order remains and you must change it from here before restarting the slideshow for it to take effect.
Actual behavior:

The folder image loading order remains fixed regardless of any changes made during an active slideshow.

Expected behavior:

The folder image loading order should update immediately based on updated selections made during slideshow.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.