d07RiV / d07RiV/blizzget

Invalid computation of block hash in Blizzget

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
86
Forks
37
PR merge metrics
No merged PRs in 30d

Description

The function `void DataStorage::writeIndex()` improperly calculates the Jenkins hash of the index data

Function:
https://github.com/d07RiV/blizzget/blob/2764ef6a378a1a3e85bf002d946898b417d747d2/src/ngdp.cpp#L451

This is how Blizzard Downloader does it:
https://github.com/ladislav-zezula/CascLib/blob/be1f076e4fcfccab0f2eb00368d458e6576f0bbb/src/CascIndexFiles.cpp#L185

This is how Blizzget does it:
https://github.com/ladislav-zezula/CascLib/blob/be1f076e4fcfccab0f2eb00368d458e6576f0bbb/src/CascIndexFiles.cpp#L202

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.