d-edge / d-edge/Cardidy

Could we/should we replace the CardType as an enum to an object hierarchy?

Open
#5 1 comment 0 reactions 0 assignees View on GitHub
enhancement question
Dominant language
C#
Stars
50
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Regarding the use of the library, keeping an enum such as CardTypes means that users will mostly have to use a huge switch to parse the type of card (for instance, in order to add some css class to display the card logo or in order other things, true story here).

Having an object hierarchy would allow for simpler overrides and usage, and keeping the object paradigm.

Your thoughts on that? I volunteer for this task if it is accepted

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.