cyntler / cyntler/react-doc-viewer

Code smell: Usage of mustache for small translation strings

Open
#207 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
481
Forks
147
PR merge metrics
No merged PRs in 30d

Description

https://github.com/cyntler/react-doc-viewer/blob/b9d9d28f89a11bd2f22364ab96302a0ffca53642/src/hooks/useTranslation.ts#L2

Currently the build includes a 20kb library blob for mustache, which is used only for translation strings. Use-case of the library against the code given is not ideal and it can be better resolved by using `eval` expression instead, which yields less code to maintain.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.