cyclofinance / cyclofinance/cyclo.sol

Pull `underlyingSymbol` from on-chain instead of canonical JSON

Open
#49 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Solidity
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Each entry in `cyclo.sol/canonical/cyclo-site-tokens.json` carries the underlying token's `symbol` as `underlyingSymbol`. The underlying is an ERC20 with a `symbol()` accessor — once `underlyingAddress` is read on-chain, chain together: `vault.asset()` then `asset.symbol()`. Drop the `underlyingSymbol` field from the canonical JSON.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the code path that reads underlyingAddress and identify where the vault asset is resolved. Chain vault.asset() to asset.symbol(), then remove underlyingSymbol from cyclo.sol/canonical/cyclo-site-tokens.json; done means the symbol is obtained on-chain and the canonical entries no longer carry that field.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.