cyclofinance / cyclofinance/cyclo.sol

Pull `underlyingDecimals` from on-chain instead of canonical JSON

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Solidity
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Each entry in `cyclo.sol/canonical/cyclo-site-tokens.json` carries the underlying token's `decimals` as `underlyingDecimals`. The underlying is an ERC20 with a `decimals()` accessor — once `underlyingAddress` is read on-chain, chain together: `vault.asset()` then `asset.decimals()`. Drop the `underlyingDecimals` field from the canonical JSON.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with cyclo.sol/canonical/cyclo-site-tokens.json and trace the code that reads each entry's underlyingAddress on-chain. Follow the vault.asset() then asset.decimals() call chain, and run the relevant contract tests if available. Done means the canonical JSON no longer contains underlyingDecimals and the underlying token decimals are obtained on-chain.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.