cyclofinance / cyclofinance/cyclo.sol

Verify cyclo-site-tokens.json receiptAddress linkage on-chain

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Solidity
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

The fork test in `test/prod/CycloSiteTokens.prod.*.t.sol` verifies vault `decimals()`, underlying `decimals()`, and `vault.asset()` linkage for every entry in `canonical/cyclo-site-tokens.json`. The `receiptAddress` field is not verified — older vault implementations (cysFLR's `PROD_FLARE_VAULT_IMPLEMENTATION_CYSFLR = 0x35ea13bB...`) don't expose `receipt()` as a getter, and the receipt itself doesn't expose a `vault()` accessor. Need a way to verify the receipt linkage that works across all vault impl versions: either (a) a per-impl-version branch in the test that uses a specific accessor, (b) reading the manager-owner storage slot of the receipt and asserting it matches the vault, or (c) calling a vault-only function on the receipt from the vault and observing the result. Currently a manual review of `canonical/cyclo-site-tokens.json` is the only way to catch a wrong `receiptAddress`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the fork test in test/prod/CycloSiteTokens.prod.*.t.sol and compare its existing vault and asset checks with the entries and receiptAddress values in canonical/cyclo-site-tokens.json. Review the cysFLR implementation address and the available receipt linkage evidence, then define a version-compatible assertion that detects an incorrect receiptAddress across all entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.