cyclestreets / cyclestreets/cyclescape
Setting thread from ungrouped-public to group-private does not remove members not in the group
Nobody has claimed this yet.
- Dominant language
- PLpgSQL
- Stars
- 34
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
I changed the thread properties for thread 4267 from ungrouped-public to group-private (see also #796 for the background to this), but this has left members who are not part of the group in the list of subscribers.
I think in this specific scenario, members of the site who are not members of the group to which the thread has newly been assigned should be unsubscribed from the thread.
Presumably if they try to post they should be being denied.
(I have now deleted the thread though. However, this should be easy to reproduce by creating a new ungrouped-public thread and then changing its properties.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Reproduce the transition from an ungrouped-public thread to group-private, inspect the subscriber list, and verify that members outside the assigned group are removed and cannot post to the thread.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- sql
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100