cuth / cuth/postcss-pxtorem

Media queries should be in em not rem

Open
#23 1 comment 6 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.2k
Forks
173
PR merge metrics
No merged PRs in 30d

Description

Since all media queries level one units are relative to the root element, setting the media queries in rems instead of ems, is useless and reduces the support for media queries in browsers like safari 5 (which do support rems but not in media queries)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the media-query conversion logic in the PostCSS plugin and reviewing any tests covering media queries. Update the behavior so generated media queries use em units rather than rem units, then verify the existing test suite covers the browser-compatibility case.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.