cutenode / cutenode/good-first-issue
An in-range update of commander is breaking the build 🚨
- Dominant language
- JavaScript
- Stars
- 832
- Forks
- 236
- PR merge metrics
- No merged PRs in 30d
Description
## The dependency [commander](https://github.com/tj/commander.js) was updated from `4.1.0` to `4.1.1`.
🚨 [View failing branch](https://github.com/cutenode/good-first-issue/compare/master...cutenode:greenkeeper%2Fcommander-4.1.1).
This version is **covered** by your **current version range** and after updating it in your project **the build failed**.
commander is a direct dependency of this project, and **it is very likely causing it to break**. If other packages depend on yours, this update is probably also breaking those in turn.
Status Details
- ✅ **build (macOS-latest, 12.x):** null
- ✅ **build (macOS-latest, 10.x):** null
- ✅ **build (macOS-latest, 8.x):** null
- ❌ **build (windows-latest, 12.x):** There are 1 failures, 0 warnings, and 0 notices.
- ✅ **build (windows-latest, 10.x):** null
- ❌ **build (windows-latest, 8.x):** There are 1 failures, 0 warnings, and 0 notices.
- ✅ **build (ubuntu-latest, 12.x):** null
- ✅ **build (ubuntu-latest, 10.x):** null
- ✅ **build (ubuntu-latest, 8.x):** null
---
Release Notes for v4.1.1
Fixed
- TypeScript definition for
.action()should include Promise for async ([#1157])
Commits
The new version differs by 14 commits.
d5186baBump version to 4.1.137e9428Add 4.1.1 to CHANGELOGe5f316fUsenpm ciwith CI (#1164)cb54d5ffix(ts): action can be an async function (#1157)6791884Merge branch 'master' into developf31d757Add FUNDING file for enabling GitHub Sponsor on repod9627f5Merge pull request #1147 from shadowspawn/feature/changelog-lint32c26dfUse consistent list character in markdown4092956Merge branch 'master' into develop82f5157Fix diff order for 4.1 link7a480a7Add missing diff link for 4.1.0e45ae5aMerge pull request #1136 from shadowspawn/feature/update-examplesd97aaaaAdd missing diff link for 4.1.04922fb8Update examples
See the full diff
FAQ and help
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
---
Your [Greenkeeper](https://greenkeeper.io) Bot :palm_tree:
Contributor guide
Research direction
Start by checking the failing branch and reproducing the commander 4.1.1 update across the listed CI matrix, focusing on the Windows Node.js 8.x and 12.x failures. Compare the failing build output with the passing macOS and Ubuntu runs; done means the dependency update no longer breaks the Windows builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- build-system, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100