curran / curran/renderCyliner

There is a bug in there !

Open
#3 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Hello there,
and thanks for the help with your code ... but ultimately no thank you ... you are not going
to be pleased by my message today ... few years ago I stumbled upon your code and decided
to use it ... it worked great (if you correct the if (fabs(vz) < 1.0e-3) (not efficient enough) by if (vz == 0.0) eh , it worked ... and then a bug ... a case in a million ?

So you can check if for your self here are the data:

// The two points in space:
DRAW_CYLINDER_BOND:: PICKED:: a.x= -3.324548, a.y= -1.470013, a.z= -0.218306
DRAW_CYLINDER_BOND:: PICKED:: b.x= -2.474335, b.y= -2.652915, b.z= -0.218291
// The vector
DRAW_CYLINDER_BOND:: PICKED:: cx= 0.850213, cy= -1.182903, cz=0.000015
// The parameters of the rotation
DRAW_CYLINDER_BOND:: PICKED:: ax= 89.999404, rx= 0.000018, ry= 0.000013

As you can see it the parameters fit none of the tests in your code ...
And the result it produces (I am drawing the half bond in blue):

![capture d ecran de 2016-09-16 13-41-28](https://cloud.githubusercontent.com/assets/22236440/18584820/833c9b1e-7c13-11e6-9da6-bcfe013c71f1.png)

The only option is to use this kind of code:

https://gist.github.com/mfalda/11182888

Best a regards and thank you anyway, it was helpful.

S.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.