cuenca-mx / cuenca-mx/cuenca-validations
move related_transaction out of QueryParams
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3
- Forks
- 0
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 6
Description
related_transaction should not be directly specified in QueryParams:
https://github.com/cuenca-mx/cuenca-validations/blob/main/cuenca_validations/types/queries.py#L32
It should be moved elsewhere
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading cuenca_validations/types/queries.py around line 32 and tracing usages of related_transaction and QueryParams. Determine where related_transaction belongs from the surrounding types and call sites; the work is done when it is no longer directly specified in QueryParams and affected validations continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100