cube-js / cube-js/lkml2cube

Console.print() got an unexpected keyword argument 'style'

Open
#14 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
13
Forks
9
PR merge metrics
No merged PRs in 30d

Description

`lkml2cube.parser.types` defines a Console class as a thin wrapper around print that is supposed to be compatible with `rich.console`, however when the 'style' kwarg is passed, rich.console _would_ work, but the wrapper does not. This is an easy fix by either removing the wrapper class and using `rich` or adding **kwargs to the wrapper's print method.

I'd be happy to open a PR fixing it, but it's unclear what the original intent of the wrapper class was, so moving back to `rich` may be undesired.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.