cube-js / cube-js/cube

Align `TableColumn` Type with `Annotation` (Client Core)

Open
#9,976 1 comment 0 reactions 0 assignees View on GitHub
client:core help wanted
Dominant language
Rust
Stars
20.8k
Forks
2.1k
Avg merge
1d 2h
Merged PRs (30d)
181

Description

**Is your feature request related to a problem? Please describe.**

We have two related types (as I believe table columns are derived from the annotation data):

https://github.com/cube-js/cube/blob/0fde75d3975d6911ec67353dacb9cfa0f62f0096/packages/cubejs-client-core/src/types.ts#L18-L27

https://github.com/cube-js/cube/blob/0fde75d3975d6911ec67353dacb9cfa0f62f0096/packages/cubejs-client-core/src/types.ts#L304-L313

I'm wondering why the types for `type` and `format` are different? I feel like `Annotation` is the correct one?

**Describe the solution you'd like**

Update the `TableColumn` type to better match `Annotation`.

**Describe alternatives you've considered**

N/A

**Additional context**

N/A

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.