cube-js / cube-js/cube

The "requestId" could be generated before "checkAuth" is called

Open
#8,518 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
20.8k
Forks
2.1k
Avg merge
1d 2h
Merged PRs (30d)
181

Description

The `checkAuth` function is called right at the beginning when Cube starts to handle a request. Because of that, I use it to print the first log message about the incoming request.

But the 'requestId' is not set in the `request` object that is given to `checkAuth`. So it is difficult to link the first log message with the subsequent log messages that already contain a requestId.

Couldn't the 'requestId' be set on the request before `checkAuth` is invoked?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.