cube-js / cube-js/cube

Migrate away from `request` and `request-promise`

Open
#8,204 2 comments 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
Rust
Stars
20.8k
Forks
2.1k
Avg merge
1d 2h
Merged PRs (30d)
181

Description

[request](https://classic.yarnpkg.com/en/package/request) and therefore [request-promise](https://www.npmjs.com/package/request-promise) have been deprecated for a while. On top of that they are dependent on an old version of `tough-cookie` for which there is a critical CVE report (CVE-2023-26136). migrating to a different request tool is highly recommended for:

- https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-backend-cloud/package.json#L29
- https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-cli/package.json#L44
- https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-schema-compiler/package.json#L81

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.