cube-js / cube-js/cube

Schema Compiler - Column names in Hebrew: support schema generation for non ASCII table names

Open
#5,174 3 comments 2 reactions 0 assignees View on GitHub
help wanted
Dominant language
Rust
Stars
20.8k
Forks
2.1k
Avg merge
1d 2h
Merged PRs (30d)
181

Description

**Describe the bug**
When generating my cube with the schema compiler, column names in Hebrew letters are trimmed and a empty key dimension is generated.

**To Reproduce**
Steps to reproduce the behavior:
1. Generate a schema with the schema compiler in localhost:4000/playground with Hebrew column names.
2. You'll notice that generated dimensions key's that suppose to have Hebrew letters are empty.

```
cube(`TableNameWithHebrewColumnName`, {
sql: `SELECT * FROM "TableName"."TableNameWithHebrewColumnName"`,

preAggregations: {
// Pre-Aggregations definitions go here
// Learn more here: https://cube.dev/docs/caching/pre-aggregations/getting-started
},

joins: {

},


dimensions: {
formNumber: {
sql: `${CUBE}."Form_Number"`,
type: `number`
},

: {
sql: `${CUBE}.`,
type: `string`,
},
},

dataSource: `default`
});
```

**Expected behavior**
To have an object with hebrew letters.

```
expected : "גיל " : {
sql: `${CUBE}.גיל `,
type: `string`,
}
```

**Version:**
@cubejs-backend/schema-compiler : 0.30.45

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.