cube-js / cube-js/cube

`shouldFetchDryRun` should consider changes made to filters

Open
#3,552 1 comment 0 reactions 0 assignees View on GitHub
client:react help wanted
Dominant language
Rust
Stars
20.8k
Forks
2.1k
Avg merge
1d 2h
Merged PRs (30d)
181

Description

**Describe the bug**
When I modify filters using `updateFilters` methods within `QueryBuilder`, a dry run does not occur as expected. Adding `filters` to the existing `shouldFetchDryRun` array (['measures', 'dimensions', 'timeDimensions']) fixes the issue.

**To Reproduce**
Steps to reproduce the behavior:
1. Call `updateFilters.add` `QueryBuilder` (`@cubejs-client/react`) to modify filters
2. A dry run does not occur

**Expected behavior**
I expect a filter change to prompt a dry run.

**Screenshots**
https://github.com/cube-js/cube.js/blob/master/packages/cubejs-client-react/src/QueryBuilder.jsx#L485-L488

**Version:**
0.28.43

**Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.