Elasticsearch - Result formatting differences
- Dominant language
- Rust
- Stars
- 20.8k
- Forks
- 2.1k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 181
Description
A recent change to conform with elaastic.co result formatting (to cope with json result) is not compatible with open distro/aws es sql result formatting. In open distro case, json formatting is more like the standard es result format whereas json format in elastic.co is more like a jdbc format.
This is the offending code.
https://github.com/cube-js/cube.js/blob/c1e25d7184c5ed63ba083da1cd9cf0f2111b8011/packages/cubejs-elasticsearch-driver/driver/ElasticSearchDriver.js#L86
We perhaps need to split the driver in some way - either entirely or certainly the query and driver.
I am happy to look at PR for this
**To Reproduce**
setting result format to json while using awses/open distro - json result formatting results in an exception
**Expected behavior**
Both open distro and elastic.co should be supported either via single driver or multiple
**Version:**
latest
Contributor guide
Assessment
This issue has not been assessed yet.