cuappdev / cuappdev/uplift-ios

Refactor: GymDetailViewController Sections

Open
#207 0 comments 0 reactions 4 assignees Claimed by @kevinchan159 View on GitHub
Type: Refactor
Dominant language
Swift
Stars
18
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Currently, inside `GymDetailViewController` we define an enum `Section` follows:
```
// MARK: - Private classes/enums
private struct Section {
var items: [ItemType]
}
```
and then define `var sections: [Section]` to just be:
```
self.sections = [
Section(items: [.hours, .busyTimes, .facilities, .classes([])])
]
```
This means that what we end up with is just one giant section with 4 cells.

We should change this so that we have 4 sections, with one cell in each. This is will help reduce with the increasingly nested view hierarchy we have

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.