cuappdev / cuappdev/score-ios

Feedback points from previous semester

Open
#31 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Comments received last semester from Noah (prev team lead):

- Horizontal scrolls should have the padding within them, since the padding is on the parent it looks weird when ur scrolling
- the tab navigator bar is also super tall, use the native hieight
- The details countdown doesn’t tick in realtime and the hourglass icon could prolly be smaller
- Are the detail views native view controllers? The headers don’t look native and I can’t swipe to go back, probably a small fix to make it feel more native
- Empty states on the home screen don’t have bottom padding
- Nice job on pagination - probably don’t need a “load more” button, you can just load the next page when the user scrolls to end
some images/logos aren’t loading - see the Binghamton screenshot
- A lot of game locations say “n/a”, maybe just hide it for that game if there’s not enough data

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.