ctrf-io / ctrf-io/github-test-reporter

Previous Runs no longer have correct build information associated with them

Open
#225 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
376
Forks
42
PR merge metrics
No merged PRs in 30d

Description

It appears the changes introduced in https://github.com/ctrf-io/github-test-reporter/pull/190 had the side effect of no longer populating the build info on the previous reports.

Specifically this change

https://github.com/ctrf-io/github-test-reporter/commit/3a9238b99ab2647267d85da6c6c91a78056b8fbe#diff-681b6868c3a2f935c94092bcf02b10d07f03497663704a929767c31e3f37847dL119

The effect is the the environment is no longer populated with the run details to provide the buildId, buildName, buildNumber and buildUrl

This routine needs to be added back in and updated to store the info in environment directly (as opposed to environment.extra)

https://github.com/ctrf-io/github-test-reporter/commit/3a9238b99ab2647267d85da6c6c91a78056b8fbe#diff-49f41e84b3c3c5cde58b0b153342848a5c859ea297bcdaaa762075bf3fc85812L551-L575

As contrary to the TODO comment, it is not duplication, as it pulls the information from a different source (workflow run vs GithubContext)

Example:

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting PR #190 and the two referenced commit diffs to find the routine that populates environment data for previous reports. Restore the workflow-run details in environment, including buildId, buildName, buildNumber, and buildUrl, then verify that previous reports display the correct build information.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.