csstools / csstools/stylelint-use-nesting

Comments break `use-nesting`

Open
#21 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
50
Forks
12
Avg merge
20h 49m
Merged PRs (30d)
2

Description

Consider the following code:

```css
.foo {
margin-top: 10px;
}

.foo:first-child {
margin-top: unset;
}
```

If you have configured Stylelint to enable this plugin, then you'll correctly receive a linting error:

```
Expected ".foo:first-child" inside of ".foo". (csstools/use-nesting)
```

However, if you have any kind of comment between the two style declarations, then you no longer get a linting error. Eg.:

```diff
.foo {
margin-top: 10px;
}

+/**
+ * This comment breaks the linting!
+ */
.foo:first-child {
margin-top: unset;
}
```

I've read in https://github.com/csstools/stylelint-use-nesting/issues/9 that it would be difficult to implement this plugin for non-sequential nodes, but it seems like it would be sensible to make a special exception for non-styling nodes like comments, no?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.