cssinjs / cssinjs/jss

Throw Error instead of warning when running tests

Open
#891 6 comments 0 reactions 0 assignees View on GitHub
help wanted idea important
Dominant language
JavaScript
Stars
7.1k
Forks
386
PR merge metrics
No merged PRs in 30d

Description

I see in the logs many warnings, which I think shouldn't be there, which means we are ignoring problems without noticing in the CI.

I am wondering if we should replace the warning when running tests with a function that throws errors so that our tests can't ignore them.

As a bonus we won't ned to rewire in so many places, but instead use expect for catching.

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by locating the warnings emitted while tests run and review where test setup currently rewires them; compare that with the existing expect-based error handling. Done means test runs fail on problems that currently produce warnings, without unnecessary rewiring.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.