cssinjs / cssinjs/jss

Deprecation warning of componentWillUpdate

Open
#1,182 2 comments 8 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
7.1k
Forks
386
PR merge metrics
No merged PRs in 30d

Description

Upgrading to React 16.9.0, I see warnings for all my components using JSS, for instance:

```
react-dom.development.js:11495 Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Jss(InformationPage)
```

I wonder if there will be a fix for these warnings before the release of v10? We are many developers on a project and are unsure whether to upgrade to v10 alpha now, to get rid of them, or there will be a release in-between to fix this?

Best,
Jan

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.