JssProvider should use jss instance's generateId method when jss is passed down to its props
- Dominant language
- JavaScript
- Stars
- 7.1k
- Forks
- 386
- PR merge metrics
- No merged PRs in 30d
Description
__Expected behavior:__
`JssProvider` should use the jss instance's generateId method when `jss` is passed down to its props and `generateId` prop is not passed down.
__Describe the bug:__
`JssProvider` creates it's own `generateId` method although it's already been defined in the `jss` instance passed in props.
__Versions:__
- jss: 10.0.0-alpha.24
- Browser [e.g. chrome, safari]: N/A
- OS [e.g. Windows, macOS]: N/A
Contributor guide
Research direction
Locate the JssProvider implementation and inspect how it selects generateId when a jss prop is supplied without an explicit generateId prop. Check the surrounding tests or add coverage for this fallback; done means the provider uses the supplied JSS instance's generateId method in that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100