csrc-sdsu / csrc-sdsu/mole

No orientation guard anywhere

Open
#456 0 comments 0 reactions 1 assignee Claimed by @manuelvalera View on GitHub
C++ Enhancement Octave/MATLAB
Dominant language
MATLAB
Stars
41
Forks
85
Avg merge
2d 31m
Merged PRs (30d)
7

Description

Following from #454 and #453 : there is no `abs(J)`, no `sign(J)`, no assertion and no
warning about negative or vanishing Jacobians anywhere in `src/octave` or
`src/cpp`. Carrying the signed Jacobian is the right design; not being able to
find out that you are on the wrong side of it is the problem.

A one-line check in `jacobian2D` / `jacobian3D` — warn if `any(J < 0)` or if
`min(J)` and `max(J)` differ in sign — would have surfaced 2 and 3 immediately
and costs nothing.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.