cspotcode / cspotcode/retries

Discord code review

Open
#1 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

https://discord.com/channels/508357248330760243/508357707602853888/951205838461227118

Things brought up during code review:

- `Matches` is unclear; depends on lodash. Reviewer felt they would always use a user-supplied function
- consider making the lodash dependency lazy-load and optional
- double-check types for `isMatch`
- my `Thrown` type is `any`; will this cause runtime failures with `isMatch`? Should be called out in docs?
- decision to expose `Date` was questioned. Think about potential use-cases. Does it make more sense to expose `+new Date` instead of `new Date()`?
- I'm currently leaning against this.
- exposing a full date instance makes semantics a bit clearer
- consider exposing namespace properties as named exports, too
- how does this compose with "abort" mechanisms and standards?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.