csnover / csnover/TraceKit

Fix flakey tests

Open
#77 0 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
JavaScript
Stars
1.1k
Forks
162
PR merge metrics
No merged PRs in 30d

Description

There are five flakey tests that have to do with ensuring the `window.onerror` is called and works properly. This needs to be mocked or figure out why the test occasionally hangs.

```
- should pass undefined:undefined...
log: window.onerror(undefined, undefined, 1337, undefined)

log: matches test message and line number
X should pass undefined:undefined
Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) (1)
>> Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
>> at
when no 5th argument (error object)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.