csharpfritz / csharpfritz/CoreWiki

ASP.NET Identity is referencing CoreWiki.Core directly

Open
#296 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
CSS
Stars
438
Forks
159
PR merge metrics
No merged PRs in 30d

Description

The code of ASP.NET Identity is using the domain object CoreWikiUser directly. There is also no abstraction of the Identity code, making it impossible to refactor it out to the Application layer.

The issue has been raised before in the Identity repo: https://github.com/aspnet/Identity/issues/883
As that issue states it has been fixed, maybe we need to look what consequences that has for our code and how we can improve it to achieve that separation.

The documentation can help there as well as it show how to create a IUserStore: https://docs.microsoft.com/en-us/aspnet/core/security/authentication/identity-custom-storage-providers?view=aspnetcore-2.1
That takes at least the EF out of the equation. UserManager is going to be trickier, not sure yet whether that is needed. It depends on whether the session lives at the front-end or the back-end. If it's front-end only, then the mobile/API back-end (once created) might need its own depending on the functionality being exposed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.