csharpfritz / csharpfritz/CoreWiki
Implied consent for password reset
Open
bug
- Dominant language
- CSS
- Stars
- 438
- Forks
- 159
- PR merge metrics
- No merged PRs in 30d
Description
Should we remove this check for consent?
https://github.com/csharpfritz/CoreWiki/blob/dev/CoreWiki.Notifications/NotificationService.cs#L89-L92
It not only doesn't stop processing after the consent check fails, but if a user requested a password reset, isn't consent implied?
If it's the case of a malicious user requesting password resets, the end user probably wants to know about that.
Perhaps we should implement rate limiting for reset requests.
Contributor guide
Assessment
This issue has not been assessed yet.